Sons of top Trump administration officials made billions for their families, but their investors didn’t always fare so well.